[Lldb-commits] [lldb] [lldb] Remove .noindex suffix from test output directory for non-Darwin (PR #197237)

[Dave Lee via lldb-commits]

================
@@ -13,7 +15,10 @@ class ModuleCacheSanityTestCase(TestBase):
     NO_DEBUG_INFO_TESTCASE = True
 
     def test(self):
+        build_dir_name = (
+            "lldb-test-build.noindex" if sys.platform == "darwin" else "lldb-test-build"
+        )
         self.expect(
             "settings show symbols.clang-modules-cache-path",
-            substrs=["lldb-test-build.noindex", "module-cache-lldb"],
+            substrs=[build_dir_name, "module-cache-lldb"],
----------------
kastiglione wrote:

I think it would be fine to simplify this to:

```py
substrs=["lldb-test-build", "module-cache-lldb"]
```

This works whether the name is "lldb-test-build.noindex" or "lldb-test-build", and makes this file a 8 character change.

https://github.com/llvm/llvm-project/pull/197237