[Lldb-commits] [PATCH] D122859: [trace] Show ideas for the main interfaces for new HTR

[walter erquinigo via Phabricator via lldb-commits]

wallace created this revision.
wallace added reviewers: davidca, clayborg, jj10306.
Herald added a project: All.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This diff tries to show the low level structures and the high level APIs for interacting with HTR (hierarchical trace representation). Most of the ideas are commented in the code. I want to get some feedback with this diff, but the actual implementation would be left for other diffs.

I describe in the code two storage strategies: in memory and on disk. Besides that, I mention two extensions: a time analyzer and a symbol index. I don't intent to implement them right away. I'm thinking about starting with the in memory one without adding many abstractions to the code, and also I'd implement first only the time analyzer. Later, we could continue implemeting the other parts mentioned in this diff, but at least I want to think about them now to make sure the basic design doesn't need a complete redesign once we want to add the other features.

What I don't include here is the algorithm for creating the call tree. That's out of the scope of this diff. I want to focus first on the interfaces, as that's the part that should change the least. The algorithm can be implemented incrementally.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122859

Files:
  lldb/include/lldb/Target/TraceHTR.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122859.419608.patch
Type: text/x-patch
Size: 16747 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220401/201091d9/attachment-0001.bin>