[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

Thu May 27 11:43:09 PDT 2021

mib requested changes to this revision.
mib added a comment.
This revision now requires changes to proceed.

At first sight, this looks like a fair addition, but this feature is also used to report Swift Runtime Failure in the debugger <https://github.com/apple/llvm-project/commit/87a24bddebb6b18d129c6ec5671ac0c5e8f3a02b> (and Xcode) ...

However, a Swift Runtime Failure is triggered as an exception not a signal so your change would break the feature. May be we could add a method that looks up the current `StopReason` in a list of supported stop reasons before selecting the most relevant frame ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103271/new/

https://reviews.llvm.org/D103271