[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

[Jim Ingham via Phabricator via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.

It is incorrect to say that SelectMostRelevantFrame is only relevant for asserts.  The FrameRecognizer is a generic mechanism, and you have no a priori way to know what kinds of thread stops it wants to operate on.  So this patch is not correct.

Other than calling the Frame Recognizers, SelectMostRelevantFrame does NOT trigger a stack walk itself.

So if there is a frame recognizer that is doing a frame walk on threads that aren't relevant to it, then changing the frame recognizer to check that the stop reason of its thread makes sense before doing any work seems a better solution to your problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103271/new/

https://reviews.llvm.org/D103271