[Lldb-commits] [lldb] a3a9528 - [lldb] X-FAIL TestCPPStaticMembers on Windows

[Raphael Isemann via lldb-commits]

Author: Raphael Isemann
Date: 2021-05-25T13:10:19+02:00
New Revision: a3a95286a73fddc4027de930fac29728cd4259fc

URL: https://github.com/llvm/llvm-project/commit/a3a95286a73fddc4027de930fac29728cd4259fc
DIFF: https://github.com/llvm/llvm-project/commit/a3a95286a73fddc4027de930fac29728cd4259fc.diff

LOG: [lldb] X-FAIL TestCPPStaticMembers on Windows

This was originally failed because of llvm.org/pr21765 which describes that
LLDB can't call a debugee's functions, but I removed the (unnecessary)
function call in the rewrite. It seems that the actual bug here is that we
can't lookup static members at all, so let's X-FAIL the test for the right
reason.

Added: 
    

Modified: 
    lldb/test/API/lang/cpp/static_members/TestCPPStaticMembers.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/lang/cpp/static_members/TestCPPStaticMembers.py b/lldb/test/API/lang/cpp/static_members/TestCPPStaticMembers.py
index 8acf498bb7f7..07ec5c52ea4c 100644
--- a/lldb/test/API/lang/cpp/static_members/TestCPPStaticMembers.py
+++ b/lldb/test/API/lang/cpp/static_members/TestCPPStaticMembers.py
@@ -15,7 +15,8 @@ class TestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
+    # We fail to lookup static members on Windows.
+    @expectedFailureAll(oslist=["windows"])
     def test_access_from_main(self):
         self.build()
         lldbutil.run_to_source_breakpoint(self, "// stop in main", lldb.SBFileSpec("main.cpp"))
@@ -24,6 +25,8 @@ def test_access_from_main(self):
         self.expect_expr("my_a.s_b", result_type="long", result_value="2")
         self.expect_expr("my_a.s_c", result_type="int", result_value="3")
 
+    # We fail to lookup static members on Windows.
+    @expectedFailureAll(oslist=["windows"])
     def test_access_from_member_function(self):
         self.build()
         lldbutil.run_to_source_breakpoint(self, "// stop in member function", lldb.SBFileSpec("main.cpp"))