[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Sep 11 16:15:46 PDT 2019
jingham added a comment.
This seems like the right place to put it, it's clearly something you would do with a process.
I don't see any reason why this should be a private function. It's just a convenience wrapper around a bunch of other public functionality, and doesn't do anything that needs to be hidden from clients of Process. I wouldn't want somebody else to reinvent it if they needed to do the same thing.
However, InferiorCall is a pretty vague name for something that has a very specific task. Once it is part of Process, the "Inferior" bit is unnecessary, the Process IS the inferior... Maybe just CallVoidArgVoidPtrReturn? That's not too hideous.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67472/new/
https://reviews.llvm.org/D67472
More information about the lldb-commits
mailing list