[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/function/TestLibCxxFunction.py:31
+        self.expect("log timers dump",
+                   patterns=["(?!lldb_private::Module::FindSymbolsMatchingRegExAndType).*"])
+
----------------
friss wrote:
> Does this negative lookahead regex actually fail if FindSymbolsMatchingRegExAndType is in the output? I would expect the `.*` afterwards to match basically anything, including what you have in your negative lookahead or another line of the output.
Good catch, I was trying to be too clever and forgot how it worked.

This is more easily done using `matching=False`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67111/new/

https://reviews.llvm.org/D67111