[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

Konrad Wilhelm Kleine via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 10 12:55:41 PDT 2019


kwk marked an inline comment as done.
kwk added a comment.

@JDevlieghere I change the support tool. It was @labath who requested (D66791#inline-601050 <https://reviews.llvm.org/D66791#inline-601050>) to outsource this patch. In that change you can find the whole reason which is somewhat more longish:

> Let's put this bit into a separate patch. As I said over IRC, I view this bit as functionally independent of the debugdata stuff (it's definitely independent in it's current form, as it will kick in for non-debugdata files too, which I think is fine).

But apart from that I think the comment indeed needs to change. Anyway, please let me know if the connection to the other change D66791 <https://reviews.llvm.org/D66791> does make sense to you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67390/new/

https://reviews.llvm.org/D67390





More information about the lldb-commits mailing list