[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

[Fangrui Song via Phabricator via lldb-commits]

MaskRay added inline comments.


================
Comment at: lldb/source/Host/common/LZMA.cpp:124
+                       llvm::SmallVectorImpl<uint8_t> &Uncompressed) {
+  if (InputBuffer.size() == 0)
+    return llvm::createStringError(llvm::inconvertibleErrorCode(),
----------------
empty


================
Comment at: lldb/source/Host/common/LZMA.cpp:129
+  uint64_t uncompressedSize = 0;
+  auto err = getUncompressedSize(InputBuffer, uncompressedSize);
+  if (err)
----------------
if (auto err = ...)
  return err;


================
Comment at: lldb/source/Host/common/LZMA.cpp:136
+  // Decompress xz buffer to buffer.
+  uint64_t memlimit(UINT64_MAX);
+  size_t inpos = 0;
----------------
= is more common


================
Comment at: lldb/source/Host/common/LZMA.cpp:138
+  size_t inpos = 0;
+  inpos = 0;
+  size_t outpos = 0;
----------------
stray `inpos = 0;`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66791/new/

https://reviews.llvm.org/D66791