[Lldb-commits] [PATCH] D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes.

Adrian McCarthy via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 14 11:49:13 PDT 2016

amccarth added inline comments.

Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:338
@@ -315,4 +337,3 @@
     // truncated.
-    error.SetErrorString("address is not in a known range");
     return error;
hhellyer wrote:
> Asking for an address outside a known range is not actually an error, you just get back an unmapped range that specifies how far it is to the next mapped range.
> The original discussion about that happened here: https://reviews.llvm.org/D21751 - GetMemoryRegionInfo should only need to return an error if it is unimplemented. (I should probably have referenced that in the summary.)
Got it.  Thanks for the explanation!

Given that, should the condition on 284 ("the mini dump contains no memory range information") actually return an error or just an unmapped range?


More information about the lldb-commits mailing list