[flang-commits] [PATCH] D129156: Add -fpass-plugin option to Flang

[Rainer Orth via Phabricator via flang-commits]

ro added a comment.

This introduced a new failure on Solaris:

  FAIL: Flang :: Driver/pass-plugin-not-found.f90

Running the failing command manually shows:

  error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': ld.so.1: flang-new: X.Y: open failed: No such file or directory'

while the test currently expects

  error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': X.Y: cannot open shared object file: No such file or directory'

This expectation is unjustified, I believe: the message is produced by `PassPlugin::Load` -> `sys::DynamicLibrary::getPermanentLibrary` -> `HandleSet::DLOpen` -> `::dlerror`.  Obviously the output of the last is system-dependent; I don't think we can put any requirements on it (maybe not even the exact wording of the `No such file or directory` part.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129156/new/

https://reviews.llvm.org/D129156