[flang-commits] [PATCH] D129156: Add -fpass-plugin option to Flang

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski added a comment.

In D129156#3949156 <https://reviews.llvm.org/D129156#3949156>, @ro wrote:

> This introduced a new failure on Solaris:
>
>   FAIL: Flang :: Driver/pass-plugin-not-found.f90
>
> Running the failing command manually shows:
>
>   error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': ld.so.1: flang-new: X.Y: open failed: No such file or directory'
>
> while the test currently expects
>
>   error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': X.Y: cannot open shared object file: No such file or directory'
>
> This expectation is unjustified, I believe: the message is produced by `PassPlugin::Load` -> `sys::DynamicLibrary::getPermanentLibrary` -> `HandleSet::DLOpen` -> `::dlerror`.  Obviously the output of the last is system-dependent; I don't think we can put any requirements on it (maybe not even the exact wording of the `No such file or directory` part.

Sorry that you are hitting this - things like this happen, sadly. I think that the easiest to resolve it would be to tweak the expected error so that it works on Solaris as well as other popular platforms. Given that you might be the only person able to test on Solaris, would you be able to upload something for  a review? Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129156/new/

https://reviews.llvm.org/D129156