[flang-commits] [PATCH] D137634: [flang][RFC] Do not rely on attributes to tag HLFIR variable uses

[Peixin Qiao via Phabricator via flang-commits]

peixin accepted this revision.
peixin added a comment.

One thing I am not clear is that when do you plan to use fir.declare given hlfir.declare is used. Why is the debug info not added to hlfir.declare directly?



================
Comment at: flang/docs/HighLevelFIR.md:97
+and if the hlfir.declare cannot be found, the transformation passe will have to
+assume that the variable may be non contiguous.
+
----------------



================
Comment at: flang/docs/HighLevelFIR.md:288
+hlfir.declare of its variable operands, the operation codegen will be allowed
+to replaced the %var#0 reference by the simpler %var#1 reference.
 
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137634/new/

https://reviews.llvm.org/D137634