[flang-commits] [PATCH] D137634: [flang][RFC] Do not rely on attributes to tag HLFIR variable uses

[Jean Perier via Phabricator via flang-commits]

jeanPerier marked 3 inline comments as done.
jeanPerier added a comment.

> One thing I am not clear is that when do you plan to use fir.declare given hlfir.declare is used. Why is the debug info not added to hlfir.declare directly?

Lowering from the parse tree will only generate hlfir.declare, then in the HLFIR to FIR conversion pass that gets rid of HLFIR operations, hlfir.declare will be translated to fir.declare that is slightly simpler.

hlfir.declare conveys the information that will allow generate variable debug info, and this role is then transmitted to fir.declare until LLVM IR dialect is generated and DIE debug info is actually generated (as I envision it, there is no detailed plan for debug info yet).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137634/new/

https://reviews.llvm.org/D137634