[Openmp-commits] [llvm] [openmp] [Runtimes] Drop 'flang' from runtimes configure dependency (PR #198205)

[Michael Kruse via Openmp-commits]

================
@@ -115,6 +115,27 @@ macro(append_passthrough_options out type names)
   endforeach()
 endmacro()
 
+# Wire build-order dependencies on flang for targets that invoke it. This allows
+# us to build the runtimes separately without first building flang.
+macro(add_flang_mod_deps build_target extra_targets_list)
+  if(TARGET flang)
+    set(_fortran_deps flang)
+    if(TARGET module_files)
+      list(APPEND _fortran_deps module_files)
+    endif()
+    if(TARGET ${build_target})
+      add_dependencies(${build_target} ${_fortran_deps})
+    endif()
+    foreach(tgt IN LISTS ${extra_targets_list})
+      if(tgt MATCHES "-mod($|-)")
----------------
Meinersbur wrote:

Could you add a comment that this is meant for install-flang-rt-mod(-stripped) and install-libomp-mod(-stripped) that install modules and therefore obviosly need flang?

Also, is ${build_target} target meant to be the "all" target that builds everything including the modules?

https://github.com/llvm/llvm-project/pull/198205