[Openmp-commits] [llvm] [openmp] [Runtimes] Drop 'flang' from runtimes configure dependency (PR #198205)

[Michael Kruse via Openmp-commits]

================
@@ -88,15 +88,20 @@ if (CMAKE_Fortran_COMPILER)
   # cannot use CMAKE_Fortran_COMPILER_ID.
   cmake_path(GET CMAKE_Fortran_COMPILER STEM _Fortran_COMPILER_STEM)
   if (_Fortran_COMPILER_STEM STREQUAL "flang-new" OR _Fortran_COMPILER_STEM STREQUAL "flang")
+    # Force the compiler ID so CMake does not try to run the compiler for
+    # identification. In a bootstrapping build the Flang binary may not be
+    # built yet at configure time (only CMAKE_Fortran_COMPILER_WORKS is set).
----------------
Meinersbur wrote:

Did you consider doing this only in a bootstrapping-build (`LLVM_TREE_AVAILABLE`)? Did you try out setting these externally, i.e. in [ `llvm/runtimes/CMakeLists.txt`](https://github.com/llvm/llvm-project/blob/main/llvm/runtimes/CMakeLists.txt) ?

In other words, is this the intended use case only bootstrapping builds or should users also be able to not need to build flang when they configure a runtimes-standalone build against some other LLVM_BINARY_DIR?

https://github.com/llvm/llvm-project/pull/198205