[Openmp-commits] [PATCH] D133692: OpenMP: Remove -fno-experimental-isel flag from testing

[Matt Arsenault via Phabricator via Openmp-commits]

arsenm created this revision.
arsenm added reviewers: Hahnfeld, OpenMP, rovka, aemerson.
Herald added subscribers: guansong, kristof.beyls, yaxunl, mgorny.
Herald added a project: All.
arsenm requested review of this revision.
Herald added subscribers: sstefan1, wdng.
Herald added a reviewer: jdoerfert.

This effectively reverts 6f9e25d3824fb7b03dc6a403e1962d80a9c88ebe.

      

I didn't follow the complete history, but it seems this was added due
to AArch64's output changing in some fallback. Blockaddress definitely
works now, so just remove this.


https://reviews.llvm.org/D133692

Files:
  openmp/cmake/DetectTestCompiler/CMakeLists.txt
  openmp/cmake/OpenMPTesting.cmake


Index: openmp/cmake/OpenMPTesting.cmake
===================================================================
--- openmp/cmake/OpenMPTesting.cmake
+++ openmp/cmake/OpenMPTesting.cmake
@@ -154,8 +154,7 @@
     set(OPENMP_TEST_COMPILER_HAS_TSAN_FLAGS 0)
   endif()
   set(OPENMP_TEST_COMPILER_HAS_OMP_H 1)
-  # TODO: Implement blockaddress in GlobalISel and remove this flag!
-  set(OPENMP_TEST_COMPILER_OPENMP_FLAGS "-fopenmp ${OPENMP_TEST_COMPILER_THREAD_FLAGS} -fno-experimental-isel")
+  set(OPENMP_TEST_COMPILER_OPENMP_FLAGS "-fopenmp ${OPENMP_TEST_COMPILER_THREAD_FLAGS}")
   set(OPENMP_TEST_COMPILER_HAS_OMIT_FRAME_POINTER_FLAGS 1)
 endif()
 
Index: openmp/cmake/DetectTestCompiler/CMakeLists.txt
===================================================================
--- openmp/cmake/DetectTestCompiler/CMakeLists.txt
+++ openmp/cmake/DetectTestCompiler/CMakeLists.txt
@@ -30,20 +30,6 @@
 set(C_FLAGS "${OpenMP_C_FLAGS} ${CMAKE_THREAD_LIBS_INIT}")
 set(CXX_FLAGS "${OpenMP_CXX_FLAGS} ${CMAKE_THREAD_LIBS_INIT}")
 
-# TODO: Implement blockaddress in GlobalISel and remove this flag!
-if (CMAKE_C_COMPILER_ID STREQUAL "Clang")
-  check_c_compiler_flag("-fno-experimental-isel" C_HAS_EXPERIMENTAL_ISEL_FLAG)
-  check_cxx_compiler_flag("-fno-experimental-isel" CXX_HAS_EXPERIMENTAL_ISEL_FLAG)
-  macro(add_experimental_isel_flag lang)
-    if (${lang}_HAS_EXPERIMENTAL_ISEL_FLAG)
-      set(${lang}_FLAGS "-fno-experimental-isel ${${lang}_FLAGS}")
-    endif()
-  endmacro(add_experimental_isel_flag)
-
-  add_experimental_isel_flag(C)
-  add_experimental_isel_flag(CXX)
-endif()
-
 check_c_compiler_flag("-fno-omit-frame-pointer" C_HAS_OMIT_FRAME_POINTER)
 check_cxx_compiler_flag("-fno-omit-frame-pointer" CXX_HAS_OMIT_FRAME_POINTER)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133692.459436.patch
Type: text/x-patch
Size: 1735 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20220912/c533ed47/attachment.bin>