[Openmp-commits] [PATCH] D125315: [Libomptarget] Build the device runtime as a static library

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue May 10 07:49:36 PDT 2022

tianshilei1992 added inline comments.

Comment at: openmp/libomptarget/CMakeLists.txt:41
+# Build the device RTL before we set the libomptarget include directories.
jhuber6 wrote:
> tianshilei1992 wrote:
> > The order here is critical because both `openmp/libomptarget/include` and `openmp/libomptarget/DeviceRTL/include` has `Debug.h`. However, I don't think that's a good practice to use order to guard that. IMO, we need to move the global include to where it is actually being used.
> We need to change the `include_directories` to `target_include_directories` and specify it for each target. I wasn't sure if I should bother doing that for this patch.
That is the better way. No need to do it here but worth another patch. However, using order is not a good idea.

  rG LLVM Github Monorepo



More information about the Openmp-commits mailing list