[Openmp-commits] [PATCH] D125315: [Libomptarget] Build the device runtime as a static library

Tue May 10 07:45:55 PDT 2022

jhuber6 added inline comments.

================
Comment at: openmp/libomptarget/CMakeLists.txt:41
+# Build the device RTL before we set the libomptarget include directories.
+add_subdirectory(DeviceRTL)
+
----------------
tianshilei1992 wrote:
> The order here is critical because both `openmp/libomptarget/include` and `openmp/libomptarget/DeviceRTL/include` has `Debug.h`. However, I don't think that's a good practice to use order to guard that. IMO, we need to move the global include to where it is actually being used.
We need to change the `include_directories` to `target_include_directories` and specify it for each target. I wasn't sure if I should bother doing that for this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125315/new/

https://reviews.llvm.org/D125315