[Openmp-commits] [PATCH] D125315: [Libomptarget] Build the device runtime as a static library

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

This design is much better because we don't need to have one bc file for each target. What's more, it uses CMake command to compile the library, which has better dependence tracking. Just one comment on the order stuff.



================
Comment at: openmp/libomptarget/CMakeLists.txt:41
+# Build the device RTL before we set the libomptarget include directories.
+add_subdirectory(DeviceRTL)
+
----------------
The order here is critical because both `openmp/libomptarget/include` and `openmp/libomptarget/DeviceRTL/include` has `Debug.h`. However, I don't think that's a good practice to use order to guard that. IMO, we need to move the global include to where it is actually being used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125315/new/

https://reviews.llvm.org/D125315