[Openmp-commits] [PATCH] D75282: Rebase D59319 on trunk

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield marked 2 inline comments as done.
JonChesterfield added a comment.

Testing is a sore point. I haven't found an acceptably low boilerplate way to write them for this library yet - should probably take another look.



================
Comment at: openmp/libomptarget/deviceRTLs/common/src/target_region.cu:1
+//===-- target_region.cu ---- CUDA impl. of the target region interface -*-===//
+//
----------------
jdoerfert wrote:
> Is this still CUDA?
Almost nothing in the runtime is cuda anymore. I need to patch the nvptx build to let the extensions be c++. But yeah, comment could change.


================
Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:100
+                                               bool UseStateMachine,
+                                               bool RequiresDataSharing);
+
----------------
jdoerfert wrote:
> We might actually want a bitvector here. Or a struct. Either one for all functions or one for each.
It's likely to be inlined, so bool/struct may optimise better than a bitvector. I'm expecting the interfaces to change as the compiler comes online anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75282/new/

https://reviews.llvm.org/D75282