[Openmp-commits] [PATCH] D75282: Rebase D59319 on trunk

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

I added two comments. Given that this is a device runtime interface we can easily change it as we go.

When I initially wrote this I didn't add unit tests. Can we do that?



================
Comment at: openmp/libomptarget/deviceRTLs/common/src/target_region.cu:1
+//===-- target_region.cu ---- CUDA impl. of the target region interface -*-===//
+//
----------------
Is this still CUDA?


================
Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:100
+                                               bool UseStateMachine,
+                                               bool RequiresDataSharing);
+
----------------
We might actually want a bitvector here. Or a struct. Either one for all functions or one for each.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75282/new/

https://reviews.llvm.org/D75282