[Openmp-commits] [PATCH] D75282: Rebase D59319 on trunk

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

In D75282#1910507 <https://reviews.llvm.org/D75282#1910507>, @JonChesterfield wrote:

> Testing is a sore point. I haven't found an acceptably low boilerplate way to write them for this library yet - should probably take another look.


Let's postpone this for now. TBH, we need to address this but we also need to make the OMPIRBuilder generate all the target code.



================
Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:100
+                                               bool UseStateMachine,
+                                               bool RequiresDataSharing);
+
----------------
JonChesterfield wrote:
> jdoerfert wrote:
> > We might actually want a bitvector here. Or a struct. Either one for all functions or one for each.
> It's likely to be inlined, so bool/struct may optimise better than a bitvector. I'm expecting the interfaces to change as the compiler comes online anyway.
Agreed. We can also change it as we go.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75282/new/

https://reviews.llvm.org/D75282