[LLVMdev] Plan to optimize atomics in LLVM

[Robin Morisset]

Thanks for taking the time to look at the patches.

I will redo them in the way you suggest and put them on Phabricator for
review.

Cheers,
Robin


On Mon, Aug 18, 2014 at 6:16 AM, Tim Northover <t.p.northover at gmail.com>
wrote:

> Hi Robin,
>
> On 15 August 2014 21:49, Robin Morisset <morisset at google.com> wrote:
> > I have
> > attached the corresponding patches; they are not completely ready for
> review
> > (mostly missing tests), I would just like to make sure that the general
> > approach seems reasonable.
>
> I've had a quick glance at the patches, and the code seems fairly sane.
>
> But I'm not so sure about starting with a new pass then deleting the
> other two. I think it's likely to muddy the revision control history.
> I'd prefer to see a gradual evolution of the
> AtomicExpandLoadLinked.cpp (perhaps starting with a "git mv" and some
> internal renaming to stake out the intent, followed by adding and
> using the extra hooks).
>
> Cheers.
>
> Tim.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140818/9fdb74f4/attachment.html>