[LLVMdev] Plan to optimize atomics in LLVM

Tim Northover t.p.northover at gmail.com
Mon Aug 18 06:16:33 PDT 2014


Hi Robin,

On 15 August 2014 21:49, Robin Morisset <morisset at google.com> wrote:
> I have
> attached the corresponding patches; they are not completely ready for review
> (mostly missing tests), I would just like to make sure that the general
> approach seems reasonable.

I've had a quick glance at the patches, and the code seems fairly sane.

But I'm not so sure about starting with a new pass then deleting the
other two. I think it's likely to muddy the revision control history.
I'd prefer to see a gradual evolution of the
AtomicExpandLoadLinked.cpp (perhaps starting with a "git mv" and some
internal renaming to stake out the intent, followed by adding and
using the extra hooks).

Cheers.

Tim.



More information about the llvm-dev mailing list