[llvm] [GlobalIsel] Visit ICmp (PR #105991)

[Thorsten Schütt via llvm-commits]

tschuett wrote:

MaxAnalysisRecursionDepth comes from LLVM-IR. The constant is not invented by GlobalIsel. We already use it in production:
https://github.com/llvm/llvm-project/blob/90e841131aa82560b6c7d1c1840bdfc79c091b37/llvm/lib/CodeGen/GlobalISel/Utils.cpp#L1887

I never heard on a GlobalIsel Combiner review discussions of data driven decisions of, e.g., MaxAnalysisRecursionDepth.  Is 4,5,6, or 7 optimal for GlobalIsel. My feeling so far has been it is sufficient for new combines:
* tests for correctness (MIR)
* code size improvement in end-to-end tests
* https://github.com/llvm/llvm-project/pull/107721 make existing code more efficient code to execute

If these rules have changed, we should move the discussion to https://github.com/llvm/llvm-project/issues/92309




https://github.com/llvm/llvm-project/pull/105991