tschuett wrote: I said above visitICmp and matchCmpOfZero cooperate. I said several times llvm/test/CodeGen/AMDGPU/itofp.i128.ll shows evidence of the effects of this PR. Your resistance was based on naming and not on the combines or code. https://github.com/llvm/llvm-project/pull/105991