[llvm] [GlobalIsel] Visit ICmp (PR #105991)

Thorsten Schütt via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 14:59:41 PDT 2024


tschuett wrote:

> > I said above visitICmp and matchCmpOfZero cooperate.
> > I said several times llvm/test/CodeGen/AMDGPU/itofp.i128.ll shows evidence of the effects of this PR.
> > Your resistance was based on naming and not on the combines or code.
> 
> I don't feel you're making a good faith effort to listen to our concerns. I'm no longer going to participate in this PR review.

Sorry, for my bad communication.

https://github.com/llvm/llvm-project/pull/105991


More information about the llvm-commits mailing list