[llvm] [LLVM] Clang format cleanups. (PR #82184)

via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 19 07:46:00 PST 2024


cmtice wrote:

James, you are correct, most of these changes are not directly in the code I am planning to refactor. But they are in the files containing the code I want to update.  I have found out the hard way that github insists that all files in your github pull request must pass its clang format tests whether or not the code that violates the clang format is code that you've actually modified.  Furthermore, when trying to deal with this github requirement, I've found that code reviewers don't like my mixing clang-format fixups with my other code changes.

I would *love* to change this painful github workflow, but I don't have the authority to do so.

https://github.com/llvm/llvm-project/pull/82184


More information about the llvm-commits mailing list