[llvm] [LLVM] Clang format cleanups. (PR #82184)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 19 00:37:27 PST 2024


https://github.com/jh7370 commented:

So the changes look fine to me in principle. However, I'm worried this patch is running foul of the comment in the coding standards about large-scale reformatting:

> Our long term goal is for the entire codebase to follow the convention, but we explicitly do not want patches that do large-scale reformatting of existing code. On the other hand, it is reasonable to rename the methods of a class if you’re about to change it in some other way.

I suspect that your proposed next change won't touch most of the code you're proposing modifying. Am I correct?

https://discourse.llvm.org/t/rfc-clang-format-all-the-things/76614/35 discusses the situation a bit more and proposals around mass-reformatting, with the view to getting the codebase clean.

https://github.com/llvm/llvm-project/pull/82184


More information about the llvm-commits mailing list