[PATCH] D158878: [runtimes][cmake] Propagate cmake arguments.

Mark de Wever via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 6 10:52:40 PDT 2023


Mordante added inline comments.


================
Comment at: llvm/runtimes/CMakeLists.txt:398
       CMAKE_ARGS ${libc_cmake_args}
       PREFIXES ${prefixes})
     set(test_targets check-runtimes)
----------------
phosek wrote:
> We already passthrough prefixes into the default target here.
I tried this the the option `-DLIBCXX_ENABLE_STD_MODULES=ON` in D158934. Should that patch work "out-of-the-box"? If so I can retest that patch without this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158878/new/

https://reviews.llvm.org/D158878



More information about the llvm-commits mailing list