[PATCH] D158878: [runtimes][cmake] Propagate cmake arguments.

Wed Sep 6 09:59:50 PDT 2023

phosek added a comment.

In D158878#4639752 <https://reviews.llvm.org/D158878#4639752>, @ldionne wrote:

> @phosek Didn't we already support passing e.g. `LIBCXX_ENABLE_FOO` variables through the bootstrapping build? I can't find where that's done though.

We do for the default target, see my comment. @Mordante  Can you share the full CMake invocation?

================
Comment at: llvm/runtimes/CMakeLists.txt:353
                                       ${${name}_extra_args}
+                           PASSTHROUGH_PREFIXES ${RUNTIMES_CMAKE_PREFIXES}
                            EXTRA_TARGETS ${${name}_extra_targets}
----------------
This code path is only used with `LLVM_RUNTIME_TARGETS`, passing through all variables into every target is a breaking change because not all variables might be applicable to every target.

================
Comment at: llvm/runtimes/CMakeLists.txt:398
       CMAKE_ARGS ${libc_cmake_args}
       PREFIXES ${prefixes})
     set(test_targets check-runtimes)
----------------
We already passthrough prefixes into the default target here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158878/new/

https://reviews.llvm.org/D158878