[PATCH] D158878: [runtimes][cmake] Propagate cmake arguments.

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 6 11:19:30 PDT 2023


phosek added inline comments.


================
Comment at: llvm/runtimes/CMakeLists.txt:398
       CMAKE_ARGS ${libc_cmake_args}
       PREFIXES ${prefixes})
     set(test_targets check-runtimes)
----------------
Mordante wrote:
> phosek wrote:
> > We already passthrough prefixes into the default target here.
> I tried this the the option `-DLIBCXX_ENABLE_STD_MODULES=ON` in D158934. Should that patch work "out-of-the-box"? If so I can retest that patch without this one.
It should, let me know if it doesn't work and I can take a look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158878/new/

https://reviews.llvm.org/D158878



More information about the llvm-commits mailing list