[PATCH] D149095: [llvm-objdump] Support CHPE code ranges in disassembler.

Mon Jul 31 23:07:27 PDT 2023

jhenderson added a comment.

I'm off for the next few days, so I'm happy with this once the islower issue has been addressed (in a separate patch) and my comments addressed (in this patch).

================
Comment at: llvm/include/llvm/Object/COFF.h:748

+enum chpe_range_type { CHPE_RANGE_ARM64, CHPE_RANGE_ARM64EC, CHPE_RANGE_AMD64 };
+
----------------
You should explicitly assign these values, as their value is significant, it seems. Also, unless these names are spec-defined (I'm guessing they might be), they should follow the LLVM coding standards for enums (see https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly).

================
Comment at: llvm/include/llvm/Object/COFF.h:754

-enum chpe_range_type { CHPE_RANGE_ARM64, CHPE_RANGE_ARM64EC, CHPE_RANGE_AMD64 };
+  // two low bits of StartOffset contain a range type
+  static constexpr uint32_t TypeMask = 3;
----------------

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149095/new/

https://reviews.llvm.org/D149095