[PATCH] D149095: [llvm-objdump] Support CHPE code ranges in disassembler.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Oh, the pre-merge check is failing on Windows too for a test from this patch.



================
Comment at: llvm/test/tools/llvm-objdump/COFF/arm64ec.yaml:106
+## Check error handling of invalid code map RVA.
+# RUN: yaml2obj --docnum=2 %s -o %t
+# RUN: not llvm-objdump -d %t 2>&1 | FileCheck --check-prefixes=ERR %s
----------------
Nit: it's generally preferable to use different temp file names for different cases in the same test file. That way, later test cases won't overwrite the test input created for an earlier part of the test, which is useful for test debugging purposes. I suggest naming them %t1, %t2 etc, or e.g. %t-invalid for this case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149095/new/

https://reviews.llvm.org/D149095