[PATCH] D149095: [llvm-objdump] Support CHPE code ranges in disassembler.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1126
+  if (It == MappingSymbols.begin() ||
+      ((--It)->first < SectionAddress && islower(It->second)))
     return '\x00';
----------------
jacek wrote:
> MaskRay wrote:
> > Why is this `islower` change?
> CHPE ranges, marked with upper letters, can cross section section boundaries. I will add a comment to clarify that.
Please don't use ctype.h routines; they can be locale-sensitive in some cases, which can lead to weird results.  StringExtras.h has alternative routines you can use.  (It looks like there isn't an islower replacement, but feel free to add it if you need it.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149095/new/

https://reviews.llvm.org/D149095