[PATCH] D154136: [RISCV] Add SEW to RISCVInversePseudoTable

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:512
+/// and is an implementation defined mapping.
+class SEWTo3BitSEW<int sew> {
+  bits<3> s = !cond(
----------------
michaelmaitland wrote:
> craig.topper wrote:
> > Why do we need to compress it 3 bits in tablegen, but we use 8 bits in RISCVCustomBehaviour.cpp?
> I can revert it to 8. I made it 3 because it looked like we were trying to pack tightly in this class. 3 bits ID as tight as you can get to represent this encoding. We can hold off on making it 3 until we’d like to add a field to the inverse table and we need the space. Let me know what you think. 
I think I'd prefer to use raw SEW rather than new format until we really need it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154136/new/

https://reviews.llvm.org/D154136