[PATCH] D120586: [Attributor] Add AAAddressSpaceInfo to deduce address spaces

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 22:14:20 PDT 2023


tschuett added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:5971
+  /// the associated value is dead.
+  virtual int32_t getAddressSpace() const = 0;
+
----------------
jdoerfert wrote:
> no null opt anymore
Could you instead return an optional to handle invalid and unknown states?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120586/new/

https://reviews.llvm.org/D120586



More information about the llvm-commits mailing list