[PATCH] D120586: [Attributor] Add AAAddressSpaceInfo to deduce address spaces

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:11961
+
+    SmallVector<Use *> WorkList;
+
----------------
tianshilei1992 wrote:
> jdoerfert wrote:
> > No need for the vector, change the uses in the first loop.
> I think it looks more clean if we first collect all uses to be changed and then create the cast instruction as we only consider two cases here after all.
It's more complex. More complex is bad.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120586/new/

https://reviews.llvm.org/D120586