[PATCH] D120586: [Attributor] Add AAAddressSpaceInfo to deduce address spaces

[Shilei Tian via Phabricator via llvm-commits]

tianshilei1992 added a comment.

I'll rewrite the test.



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:11961
+
+    SmallVector<Use *> WorkList;
+
----------------
jdoerfert wrote:
> No need for the vector, change the uses in the first loop.
I think it looks more clean if we first collect all uses to be changed and then create the cast instruction as we only consider two cases here after all.


================
Comment at: llvm/test/Transforms/Attributor/address_space_info.ll:288
+}
+
+attributes #0 = { nounwind }
----------------
arsenm wrote:
> test intrinsics. memcpy, memmove, memset and some target ones. Also the predicates, like llvm.amdgcn.is.shared/is.private 
We only look into two kinds of interactions here. We will not need them *for now*. For sure the following patch(es) can cover cases like the runtime check of AS since we might eliminate them if feasible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120586/new/

https://reviews.llvm.org/D120586