[PATCH] D152963: [RISCV] Don't assume tail undefined if there's no policy op

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 14:26:25 PDT 2023


luke added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:3205
+  if (UseTUPseudo && I->UnmaskedTUPseudo == I->MaskedPseudo)
+    return false;
 
----------------
I think we need to add a pseudo variant for VPseudoBinaryM (and potentially others) that allows us to represent tail agnostic without a mask. @reames How would this work with the TU_ canonicalisation plan? Could we get away with adding a TU_ variant and including a policy operand, where we set ForceTailAgnostic=1?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152963/new/

https://reviews.llvm.org/D152963



More information about the llvm-commits mailing list