[PATCH] D152669: [AIX][TLS] Generate 32-bit local-exec access code sequence

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:1741
   case PPCISD::GET_TLS_ADDR:    return "PPCISD::GET_TLS_ADDR";
+  case PPCISD::GET_TPOINTER:
+                                return "PPCISD::GET_TPOINTER";
----------------
Two PPCISD nodes may be unnecessary.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:3356
     }
+    SDValue VariableOffsetTGA =
+        DAG.getTargetGlobalAddress(GV, dl, PtrVT, 0, PPCII::MO_TPREL_FLAG);
----------------
Move 3356-3358 to the top before the checks for 64-bit/32-bit.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3157
+let hasExtraSrcRegAllocReq = 1, hasExtraDefRegAllocReq = 1,
+    Defs = [R0,LR] in
+def GETtlsTpointer32AIX : PPCEmitTimePseudo<(outs gprc:$rD), (ins),
----------------
Double check if these defines are correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152669/new/

https://reviews.llvm.org/D152669