[PATCH] D152669: [AIX][TLS] Generate 32-bit local-exec access code sequence

Kamau Bridgeman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 10:19:09 PDT 2023


kamaub added a comment.

First review, I'll try to comeback again soon.



================
Comment at: llvm/lib/Target/PowerPC/PPCTLSDynamicCall.cpp:66
             MI.getOpcode() != PPC::TLSGDAIX &&
-            MI.getOpcode() != PPC::TLSGDAIX8 && !IsPCREL) {
+            MI.getOpcode() != PPC::TLSGDAIX8 && IsNotTLSTPRelMI && !IsPCREL) {
           // Although we create ADJCALLSTACKDOWN and ADJCALLSTACKUP
----------------
for me personally `!IsTLSTPRelMI` less confusing.


================
Comment at: llvm/lib/Target/PowerPC/PPCTLSDynamicCall.cpp:147
           // copies are followed by GETtlsADDR32AIX/GETtlsADDR64AIX.
+          if (IsNotTLSTPRelMI) {
           BuildMI(MBB, I, DL, TII->get(TargetOpcode::COPY), GPR4)
----------------
contents need to be indented 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152669/new/

https://reviews.llvm.org/D152669



More information about the llvm-commits mailing list