[PATCH] D144660: [compiler-rt][CMake] Properly set COMPILER_RT_HAS_LLD

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D144660#4384688 <https://reviews.llvm.org/D144660#4384688>, @phosek wrote:

> I missed the latest revision so I apologize about the late comment. I'm fine with this change but I'm worried whether this strategy is going to scale. If we need a similar variable in other runtimes, are we going to introduce more variables like `${name}_HAS_TRUNK_LLD=TRUE`, etc? I think we need a better long-term strategy that doesn't require special casing individual runtimes. Perhaps we could just passthrough `LLVM_ENABLE_PROJECTS` into the runtimes build and then do the `"lld" IN_LIST LLVM_ENABLE_PROJECTS` check in individual runtimes?

passing through `LLVM_ENABLE_PROJECTS` gives me a bunch of

  CMake Error at /usr/local/google/home/aeubanks/repos/llvm-project/llvm/cmake/modules/AddLLVM.cmake:1929 (add_dependencies):
    The dependency target "lld" of target "check-runtimes" does not exist.
  Call Stack (most recent call first):
    /usr/local/google/home/aeubanks/repos/llvm-project/llvm/cmake/modules/AddLLVM.cmake:1969 (add_lit_target)
    CMakeLists.txt:252 (umbrella_lit_testsuite_end)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144660/new/

https://reviews.llvm.org/D144660