[PATCH] D144660: [compiler-rt][CMake] Properly set COMPILER_RT_HAS_LLD

Wed May 31 11:24:03 PDT 2023

haowei added a comment.

In D144660#4384939 <https://reviews.llvm.org/D144660#4384939>, @aeubanks wrote:

> @haowei could you post the lld command before and after the patch? `bin/llvm-lit -a runtimes/runtimes-bins/compiler-rt/test/hwasan/X86_64/TestCases/sizes.cpp`

The test run with revert was conducted on a bot, I don't have shell access to manually ran any command nor do I have access to the build directory, sorry.

The task with your change reverted: https://luci-milo.appspot.com/raw/build/logs.chromium.org/fuchsia/led/haowei_google.com/44a1b91abf6fccb72bd3e88d382fb350d3647485d851446b6364cbe9008c9837/+/build.proto

The task failed with your change: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8779565760229543425/overview

I could manually verify it on my workstation and try digging into the lld invocation in this unit test. But it would take some time. If you prefer that, could you revert the change while we investigating the issue?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144660/new/

https://reviews.llvm.org/D144660