[PATCH] D144660: [compiler-rt][CMake] Properly set COMPILER_RT_HAS_LLD

Wed May 31 11:28:18 PDT 2023

aeubanks reopened this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

In D144660#4384963 <https://reviews.llvm.org/D144660#4384963>, @haowei wrote:

> In D144660#4384939 <https://reviews.llvm.org/D144660#4384939>, @aeubanks wrote:
>
>> @haowei could you post the lld command before and after the patch? `bin/llvm-lit -a runtimes/runtimes-bins/compiler-rt/test/hwasan/X86_64/TestCases/sizes.cpp`
>
> The test run with revert was conducted on a bot, I don't have shell access to manually ran any command nor do I have access to the build directory, sorry.
>
> The task with your change reverted: https://luci-milo.appspot.com/raw/build/logs.chromium.org/fuchsia/led/haowei_google.com/44a1b91abf6fccb72bd3e88d382fb350d3647485d851446b6364cbe9008c9837/+/build.proto
>
> The task failed with your change: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8779565760229543425/overview
>
> I could manually verify it on my workstation and try digging into the lld invocation in this unit test. But it would take some time. If you prefer that, could you revert the change while we investigating the issue?

I've reverted for now. My guess is that most typical bots have libstdc++ lying around but yours doesn't? Although I have no idea why this change would affect that?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144660/new/

https://reviews.llvm.org/D144660