[PATCH] D151648: [IPSCCP] Make sure Post Dominator Tree always is updated

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

In D151648#4379104 <https://reviews.llvm.org/D151648#4379104>, @xbolva00 wrote:

>>> But I prefer if things are slow rather than faulty.
>
> Both wrong, I would prefer revert of that commit and then build proper solution without any pressure.

I wouldn't mind reverts. I had preferred if this was reverted directly when the problem was reported 5 days ago. Now I think there are a couple of patches that depend on this patch that needs to be reverted as well. I think it would be nice if @labrinea would deal with it somehow.

Meanwhile I've put this up to show a lit regression test, and to highlight the code that is wrong, and to show a possible workaround for anyone else who stumble upon the same problem.
Take it or leave it :-)   (but if you leave it, please do the reverts or find a better solution)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151648/new/

https://reviews.llvm.org/D151648