[PATCH] D151648: [IPSCCP] Make sure Post Dominator Tree always is updated

Mon May 29 07:55:51 PDT 2023

bjope added a comment.

In D151648#4379141 <https://reviews.llvm.org/D151648#4379141>, @nikic wrote:

> In D151648#4379104 <https://reviews.llvm.org/D151648#4379104>, @xbolva00 wrote:
>
>>> But I prefer if things are slow rather than faulty.
>>
>> Both wrong, I would prefer revert of that commit and then build proper solution without any pressure.
>
> Right, please revert the patch and anything based on it.
>
> I checked, and (unnecessarily...) requiring the PDT here is not free: https://llvm-compile-time-tracker.com/compare.php?from=ab05d9134d18db34501985a01fbfc02609767587&to=bbb22133c4008a18559e48ebef215e7e6b5c82f0&stat=instructions:u

Thanks for checking. I kind of thought that the PDT would be calculated anyway given the use of the BFI (but I guess the BFI calculation is conditional and not done for every function).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151648/new/

https://reviews.llvm.org/D151648