[PATCH] D151648: [IPSCCP] Make sure Post Dominator Tree always is updated
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 29 07:39:44 PDT 2023
fhahn added a comment.
Thanks for catching this subtle bug and tracking this down. Unconditionally computing the post-dominator tree here seems like it could be quite expensive. Like @xbolva00 said, it would probably be worth reverting the problematic commit, add the test case and recommit an updated patch that address the problem.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151648/new/
https://reviews.llvm.org/D151648
More information about the llvm-commits
mailing list