[PATCH] D151648: [IPSCCP] Make sure Post Dominator Tree always is updated

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 29 07:37:49 PDT 2023


nikic added a comment.

In D151648#4379104 <https://reviews.llvm.org/D151648#4379104>, @xbolva00 wrote:

>> But I prefer if things are slow rather than faulty.
>
> Both wrong, I would prefer revert of that commit and then build proper solution without any pressure.

Right, please revert the patch and anything based on it.

I checked, and (unnecessarily...) requiring the PDT here is not free: https://llvm-compile-time-tracker.com/compare.php?from=ab05d9134d18db34501985a01fbfc02609767587&to=bbb22133c4008a18559e48ebef215e7e6b5c82f0&stat=instructions:u


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151648/new/

https://reviews.llvm.org/D151648



More information about the llvm-commits mailing list